Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectable Nodes Delegate #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Selectable Nodes Delegate #69

wants to merge 1 commit into from

Conversation

jz709u
Copy link

@jz709u jz709u commented Feb 1, 2017

-PointSelectedProtocol triggers on touch of node or bar
-changes to touchEnded when user lifts off at any points or bars then
return the label, value, and the point at which selected
-this is used for display for purposes or for presenting a popup at the
point location.

@jz709u
Selectable Nodes Delegate
9244e9b 
-PointSelectedProtocol triggers on touch of node or bar
-changes to touchEnded when user lifts off at any points or bars then
return the label, value, and the point at which selected
-this is used for display for purposes or for presenting a popup at the
point location.
@lex-shvets lex-shvets mentioned this pull request Mar 9, 2017
Closed
@smitaAcellere
Copy link

I did it. Thank you so much. You save my time.

@manuel21
Copy link

Hello this code has an issue that crash the app

// left point only
let leftPoint = graphPoints[leftDataPointIndex].location **//EXC_BAD_INSTRUCTION
![screen shot 2017-04-28 at 1 24 33 pm](https://cloud.githubusercontent.com/assets/7534410/25541951/363f686a-2c16-11e7-9123-c0daa320d608.png)
![screen shot 2017-04-28 at 1 24 33 pm](https://cloud.githubusercontent.com/assets/7534410/25541963/4244faee-2c16-11e7-853f-1512fb99725b.png)

**

        if shouldDrawBarLayer {
            let barWidthToRightOfX = locationOfTouchPoint.x + (barWidth / 2)
            if locationOfTouchPoint.y < leftPoint.y &&
                barWidthToRightOfX > locationOfTouchPoint.x {
                triggerDelegateWith(index: leftDataPointIndex)
            }

fatal error: Index out of range

The index is wrong when I Tap on the background instead of a point

@mithunmathew1990 mithunmathew1990 mentioned this pull request May 1, 2017
Open
@mithunmathew1990
Copy link

Please review #82
@manuel21 @philackm @jz709u

mithunmathew1990
mithunmathew1990 reviewed May 1, 2017
View reviewed changes
Copy link

@mithunmathew1990 mithunmathew1990 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In func triggerDelegateWith(index: Int) {
guard 0 <= index && index <= (labels.count - 1) else { return }

Isn't it supposed to be
guard 0 <= index || index > (labels.count - 1) else { return }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mithunmathew1990 mithunmathew1990 mithunmathew1990 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jz709u @smitaAcellere @manuel21 @mithunmathew1990